ACNA-3274 | point runtime plugin to deploy service #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… acna-3274-point-runtime-plugin-to-deploy-service
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 66 66
Lines 1745 1758 +13
Branches 369 371 +2
=========================================
+ Hits 1745 1758 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shazron
requested changes
Feb 18, 2025
arjuncooliitr
approved these changes
Feb 19, 2025
shazron
requested changes
Feb 19, 2025
shazron
reviewed
Feb 19, 2025
shazron
reviewed
Feb 19, 2025
Contributor
Author
|
Please do not merge this PR , before merging Production URL Needs to be updated. |
amulyakashyap09
changed the title
amulyakashyap09
changed the title
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
shazron
requested changes
Mar 19, 2025
Member
shazron
left a comment
shazron
left a comment
There was a problem hiding this comment.
- needs adobe/aio-lib-runtime#206 to be merged released before this is merged, add to description
- affirm that testing this works with the dev deployservice (via the apihost env var)
Contributor
Author
|
shazron
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE
Related Issue
ACNA-3274
ACNA-3602
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Feature Flag Enabled: Should give 200 with IS_DEPLOY_SERVICE_ENABLED = true
Feature Flag Disabled: Should give 401 with IS_DEPLOY_SERVICE_ENABLED = false [as ow auth_handler will not be available]
Types of changes
Checklist: